clean up profiles #175
clean up profiles #175
Conversation
cqc-melf
force-pushed
the
melf/clean-up-profiles
branch
from
9bbfffd
to
a384514
Compare
pytket/qir/conversion/api.py
Outdated
| https://github.com/qir-alliance/qir-spec/tree/main/specification/under_development/profiles/Adaptive_Profile.md | ||
| Use QIRProfile.ADAPTIVE_CREGSIZE for the adaptive profile with additional | ||
| truncation operation to assure that intergers matching the classical |
There was a problem hiding this comment.
| truncation operation to assure that intergers matching the classical | |
| truncation operation to assure that integers matching the classical |
| @@ -112,7 +112,7 @@ | |||
| } | |||
|
|
|||
|
|
|||
| class QirGenerator: | |||
| class AbsQirGenerator: | |||
There was a problem hiding this comment.
I thought of abstract which is have now written fully. Open to other suggestions.
| """ | ||
| This module contains all functionality to generate QIR files | ||
| from pytket circuits. | ||
| """ |
There was a problem hiding this comment.
Replace these "module-level" descriptions with "file-level" descriptions?
There was a problem hiding this comment.
I think this is not really helpful at the moment, I have remove this and added more details to the docs strings of the classes in the files. Maybe that is better?
| ) | ||
|
|
||
|
|
||
| class AProfileQirGenerator(AbsQirGenerator): |
There was a problem hiding this comment.
A for "adaptive"? I think using the full name would be better -- and also changing the filename to reflect this.
There was a problem hiding this comment.
Yes, it is for Adaptive, I have expended this and added some more details to the docstring of the class.
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Description
Clean up and first steps of adding support for the base profile
This PR is moving all the code used by all profiles from the two QirGenerator classes to an abstract class.
Adding support for
ADAPTIVE_CREGSIZEoption which is generating profile compatible QIR with assuring the registers size of the integers representing them. This is not yet working on the hardware, so I have not added that to the changelog.I will add the changes for the base profile in a second PR.
It might be easier to review the commits, they are structures to keep the renaming and changes in the QIR files separated from the code changes.
Related issues
Solves #168
Checklist