Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tkassert] Link tklog as public #1111

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[tkassert] Link tklog as public #1111

merged 2 commits into from
Nov 8, 2023

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Nov 8, 2023

(See #960 .)

@cqc-alec cqc-alec requested a review from doug-q November 8, 2023 09:28
@cqc-alec cqc-alec marked this pull request as ready for review November 8, 2023 09:28
@cqc-alec cqc-alec requested a review from trvto November 8, 2023 09:28
@doug-q
Copy link

doug-q commented Nov 8, 2023

My notes in the prior PR include:

tkassert must be a PUBLIC dependency of tktokenswap because the public
header VectorListHybrid.hpp includes tkassert/Assert.hpp.

Should we include this here?

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented Nov 8, 2023

My notes in the prior PR include:

tkassert must be a PUBLIC dependency of tktokenswap because the public header VectorListHybrid.hpp includes tkassert/Assert.hpp.

Should we include this here?

Was planning to do that in a second PR, where we also bump the version of tkassert that tktokenswap depends on.

@cqc-alec cqc-alec merged commit 05b4eb0 into develop Nov 8, 2023
40 checks passed
@cqc-alec cqc-alec deleted the bugfix/tkassert-pubtklog branch November 8, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants