[infra] Build fixes #960
Closed
[infra] Build fixes #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My gcc 12 toolchain needs the <algorithm> includes for std::is_sorted. tkassert must be a PUBLIC dependency of tktokenswap because the public header VectorListHybrid.hpp includes tkassert/Assert.hpp. tklog must be a PUBLIC dependency of tkassert because Assert.hpp includes tklog/TketLog.hpp.
|
Looks good! I'm not sure but I think this may warrant/require a version bump of the libraries that changed. |
trvto
requested changes
Aug 21, 2023
|
With the version bump we may need two more PRs, one to update the other libraries that depend on tkassert and then one for tket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My gcc 12 toolchain needs the includes for std::is_sorted.
tkassert must be a PUBLIC dependency of tktokenswap because the public header VectorListHybrid.hpp includes tkassert/Assert.hpp.
tklog must be a PUBLIC dependency of tkassert because Assert.hpp includes tklog/TketLog.hpp.