Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewer vote #3262

Merged
merged 15 commits into from
Feb 14, 2024
Merged

Reviewer vote #3262

merged 15 commits into from
Feb 14, 2024

Conversation

Macroz
Copy link
Collaborator

@Macroz Macroz commented Feb 2, 2024 •
edited
Loading

Close #3257

Looks like in #3185 but with functionality improvements.

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue
  • Consider adding screenshots for ease of review (not much changed)

Backwards compatibility

  • API is backwards compatible or completely new
  • Events are backwards compatible or have migrations
  • Config is backwards compatible

Documentation

  • Update changelog if necessary

Testing

  • Valuable features are integration / browser / acceptance tested automatically

Follow-up

@Macroz
tune: showing of votes when there are none
3dc3bc8 
Empty parenthesis was displayed.
@Macroz
feat: extend voting to reviewer voting
a3e8aa1 
Test both more comprehensively.
@Macroz
doc: update CHANGELOG
e7b71ec
@Macroz
fix: typo in test expection
29d9be4
@Macroz
fix: unify spelling of reviewer(s)-vote
94dc28b
@Macroz
fix: votes block
11fd55e 
- show when voters exist show, not only when votes exist so the
  handler can preview reviewers easily
- show parenthesis around voters
@Macroz
feat: add separate not-voted from empty
9cbfb03 
These should be configurable later.
aatkin
aatkin approved these changes Feb 8, 2024
View reviewed changes
src/clj/rems/application/model.clj Outdated Show resolved Hide resolved
src/clj/rems/service/test_data.clj Outdated Show resolved Hide resolved
src/cljs/rems/actions/vote.cljs Outdated Show resolved Hide resolved
src/cljs/rems/application.cljs Outdated Show resolved Hide resolved
test/clj/rems/api/test_applications.clj Outdated Show resolved Hide resolved
src/cljs/rems/actions/vote.cljs Show resolved Hide resolved
src/cljs/rems/actions/vote.cljs Outdated Show resolved Hide resolved
@Macroz
fix: remove fast trampoline
d23302c 
In a new clone of the repo, the `dev_db.sh` may not run because of some
Leiningen feature. Running `lein run dev-setup` will make it work.
@Macroz
refactor: use master workflow for base and blacklist in enrichment
220e94b 
This generates the application permissions documentation correctly,
and is how the rest of REMS works.
@Macroz
refactor: dedicated test data for voting
e53d062
@Macroz
clean: remove redundant str
4a166e2
@Macroz
feat: always show voting info
b36cc76 
- handlers will see all details right away
- handling users will always see voting "open"
- applying users will only see the minimal view (and never voting)
@Macroz
refactor: use create-user! return value
ef10a9b
@Macroz
refactor: simplify with into
528945b
@Macroz
refactor: match the common case better
72af31b 
Also could have a problem with `(when (seq ..) ...)` later.
@Macroz Macroz merged commit 589d031 into master Feb 14, 2024
7 checks passed
@Macroz Macroz deleted the reviewer-vote branch February 14, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatkin aatkin aatkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Voting for reviewers
2 participants
@Macroz @aatkin