Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo voting #3185

Merged
merged 14 commits into from
Sep 8, 2023
Merged

Demo voting #3185

merged 14 commits into from
Sep 8, 2023

Conversation

Macroz
Copy link
Collaborator

@Macroz Macroz commented Sep 8, 2023

Implements first version of #3174.

Editing workflow settings

Screenshot_2023-09-08_10-41-17

Voting for the first time

Screenshot_2023-09-08_10-43-54

Voting results and changing vote

Screenshot_2023-09-08_10-44-37

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue
  • Consider adding screenshots for ease of review

Backwards compatibility

  • API is backwards compatible or completely new
  • Events are backwards compatible or have migrations
  • Config is backwards compatible
  • Feature appears correctly in PDF print

Documentation

  • Update changelog if necessary
  • API is documented and shows up in Swagger UI
  • Components are added to guide page
  • Update docs/ (if applicable)
  • Update manual/ (if applicable)
  • ADR for major architectural decisions or experiments
  • New config options in config-defaults.edn

Testing

  • Complex logic is unit tested
  • Valuable features are integration / browser / acceptance tested automatically

Follow-up

  • New tasks are created for pending or remaining tasks

src/clj/rems/db/workflow.clj Show resolved Hide resolved
src/clj/rems/main.clj Outdated Show resolved Hide resolved
src/clj/rems/api/workflows.clj Outdated Show resolved Hide resolved
src/clj/rems/api/workflows.clj Outdated Show resolved Hide resolved
test/clj/rems/api/test_applications.clj Outdated Show resolved Hide resolved
@aatkin
Copy link
Collaborator

aatkin commented Sep 8, 2023

Added initial comments for demo. Test data could be included, e.g. enable workflow voting in "Complicated data request" application. Not strictly necessary though.

@Macroz Macroz merged commit be9b7c3 into master Sep 8, 2023
7 checks passed
@Macroz Macroz deleted the demo-voting branch September 8, 2023 10:18
@Macroz Macroz mentioned this pull request Feb 2, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants