possibly confusing count_only behavior

[ElectricNroff]

https://cveawg-test.mitre.org/api-docs/ says

GET /cve
...
count_only  Get count of records that match query. Accepted values are 0 (False) and 1 (True)
boolean
(query)

The actual behavior seems to be that "true" and "false" are also accepted, but both "true" and "false" are equivalent to 0.

https://cveawg-test.mitre.org/api/cve?assigner_short_name=snyk&count_only=true

{"cveRecords":[{"containers":{"cna":{"affected":[{"product":"zt-zip","vendor":"zeroturnaround","versions":
...

https://cveawg-test.mitre.org/api/cve?assigner_short_name=snyk&count_only=false

{"cveRecords":[{"containers":{"cna":{"affected":[{"product":"zt-zip","vendor":"zeroturnaround","versions":
...

https://cveawg-test.mitre.org/api/cve?assigner_short_name=snyk&count_only=1

{"totalCount":543}

https://cveawg-test.mitre.org/api/cve?assigner_short_name=snyk&count_only=0

{"cveRecords":[{"containers":{"cna":{"affected":[{"product":"zt-zip","vendor":"zeroturnaround","versions":
...

This seems to be caused by the interaction among:

cve-services/src/controller/cve.controller/cve.controller.js

Line 98 in 3b7608f

if (req.ctx.query.count_only === '1') {

and

cve-services/src/controller/cve.controller/index.js

Line 148 in 3b7608f

query(['count_only']).optional().isBoolean(),

and the definition of isBoolean in
https://github.com/validatorjs/validator.js/blob/master/README.md

In other words, "true" is considered a valid syntax, but the === '1' test, in effect, interprets true as false. A possible solution is to modify index.js to use

isIn(['0','1'])

instead of

isBoolean()

[slubar]

Change the endpoint to allow both 0/1 and true/false. All other values should throw an error. Swagger docs will need to be updated to reflect the change