Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#802 Update boolean query parameters to accept 0,1,true,false,yes,no … #952

Merged
merged 4 commits into from
Dec 14, 2022
Merged

#802 Update boolean query parameters to accept 0,1,true,false,yes,no … #952

merged 4 commits into from
Dec 14, 2022

Conversation

slubar
Copy link
Contributor

@slubar slubar commented Dec 14, 2022

Updates express-validator version to 6.14.2. Boolean query parameters

  • count_only for GET /cve
  • active for PUT /org/:shortname/user/:username

now accept (in any mix of upper and lower case) 0,1,true,false,yes,no

all other values are invalid

@slubar slubar requested review from jdaigneau5 and brettp December 14, 2022 16:55
@slubar slubar linked an issue Dec 14, 2022 that may be closed by this pull request
possibly confusing count_only behavior #802
Closed
@brettp brettp merged commit c9f6ce5 into dev Dec 14, 2022
@brettp brettp deleted the srl-802 branch December 14, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettp brettp brettp approved these changes

@jdaigneau5 jdaigneau5 Awaiting requested review from jdaigneau5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

possibly confusing count_only behavior
2 participants
@slubar @brettp