Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made phone_number_verified be boolean. #418

Merged
merged 3 commits into from
Aug 31, 2017
Merged

Made phone_number_verified be boolean. #418

merged 3 commits into from
Aug 31, 2017

Conversation

rohe
Copy link
Contributor

@rohe rohe commented Aug 30, 2017

Fixed bug where loading non-boolean worked for something marked as boolean.
Added tests.

Thanks for contributing to this library! Please include the following check
list in your pull request submission (you can delete this message). If your
changes don't need a change log or documentation update, please ignore this.

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.

rohe added 2 commits August 30, 2017 11:20
Fixed bug where loading non-boolean worked for something marked as boolean.
Added tests.
@rohe
Copy link
Contributor Author

rohe commented Aug 30, 2017

This replaces PR #408

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 59.867% when pulling aeefc09 on rohe:claim_boolean into 6b56e7d on OpenIDC:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 59.867% when pulling aeefc09 on rohe:claim_boolean into 6b56e7d on OpenIDC:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 59.867% when pulling aeefc09 on rohe:claim_boolean into 6b56e7d on OpenIDC:master.

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage increased (+0.01%) to 59.867% when pulling aeefc09 on rohe:claim_boolean into 6b56e7d on OpenIDC:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 59.86% when pulling 5258930 on rohe:claim_boolean into 6b56e7d on OpenIDC:master.

@coveralls
Copy link

coveralls commented Aug 31, 2017

Coverage Status

Coverage increased (+0.01%) to 59.867% when pulling 5258930 on rohe:claim_boolean into 6b56e7d on OpenIDC:master.

@decentral1se
Copy link
Contributor

LGTM 🍻 🍻 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants