Skip to content
This repository has been archived by the owner on Sep 1, 2020. It is now read-only.

Types for claims returned not being checked #40

Closed
selfissued opened this issue Jul 20, 2017 · 4 comments
Closed

Types for claims returned not being checked #40

selfissued opened this issue Jul 20, 2017 · 4 comments
Assignees
@rohe
Labels
bug
Milestone
OP Release 2.0.7

Comments

@selfissued
Copy link

We are not flagging it when claims are returned with the wrong JSON types. For instance, the Mvine results returned "middle_name": null - which isn't a string as required and "updated_at": "20170328081544Z" - when a number is required. These results currently are PASSED whereas they should be FAILED.

We should also be issuing WARNINGs when empty strings are returned as claim values - such as "middle_name": "".
@zandbelt zandbelt added the bug label Jul 25, 2017
@zandbelt zandbelt added this to the OP Release 2.0.6 milestone Jul 25, 2017
@rohe
Copy link

rohe commented Jul 28, 2017

This needs an update to pyoidc. I have issued a Pull Request with the necessary enhancements.

@zandbelt zandbelt removed this from the OP Release 2.0.6 milestone Jul 31, 2017
@zandbelt zandbelt added this to the OP Release 2.0.7 milestone Sep 13, 2017
@zandbelt
Copy link

This was addressed in pyoidc here:
CZ-NIC/pyoidc#401
and here:
CZ-NIC/pyoidc#418
and is part of pyoidc version >= 0.11.0

@zandbelt
Copy link

as it appears that would pyoidc > 0.11.0.1

zandbelt added a commit that referenced this issue Oct 2, 2017
@zandbelt
release OP 2.0.7 and RP 1.0.5
cd95b98 
- use pyoidc 0.12.0 (still with a patch)
- OP: address #51, #50, #46, #40
- RP: address #44

Signed-off-by: Hans Zandbelt <hans.zandbelt@zmartzone.eu>
@zandbelt
Copy link

zandbelt commented Oct 2, 2017

pyoidc 0.12.0 is now deployed as part of OP release 2.0.7

@zandbelt zandbelt closed this as completed Oct 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rohe rohe

Labels
bug
Projects
None yet
Milestone
OP Release 2.0.7
Development

No branches or pull requests
3 participants
@rohe @zandbelt @selfissued