Sketch distribute fix (#1017) #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lorenzncode
commented
Feb 28, 2022
lorenzncode
commented
- distribute was creating an extra location
- Split distribute, rarray, parray tests
* distribute was creating an extra location * Split distribute, rarray, parray tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
+ Coverage 96.29% 96.32% +0.02%
==========================================
Files 40 40
Lines 9364 9405 +41
Branches 1101 1248 +147
==========================================
+ Hits 9017 9059 +42
Misses 204 204
+ Partials 143 142 -1 ☔ View full report in Codecov by Sentry. |
|
Marking as draft for now as this change currently also implements a nested function which I think may be frowned upon. |
* Add module level TOL
|
@lorenzncode could you merge master into this? |
adam-urbanczyk
requested changes
Mar 29, 2022
* Split params into two variables
adam-urbanczyk
approved these changes
Mar 31, 2022
jmwright
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Looks good. Thanks for all your work on this @lorenzncode !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.