Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if wires are coplanar #710

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Check if wires are coplanar #710

merged 1 commit into from
Apr 3, 2021

Conversation

adam-urbanczyk
Copy link
Member

Will resolve #709

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #710 (e57d70d) into master (7546866) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

❗ Current head e57d70d differs from pull request most recent head fd0f1f6. Consider uploading reports for the commit fd0f1f6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
- Coverage   94.54%   94.50%   -0.04%     
==========================================
  Files          32       32              
  Lines        7071     7078       +7     
  Branches      766      768       +2     
==========================================
+ Hits         6685     6689       +4     
- Misses        253      255       +2     
- Partials      133      134       +1     
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 92.37% <60.00%> (-0.16%) ⬇️
tests/test_cadquery.py 99.17% <100.00%> (+<0.01%) ⬆️
tests/test_workplanes.py 99.30% <0.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7546866...fd0f1f6. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@marcus7070 marcus7070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @adam-urbanczyk.

@marcus7070 marcus7070 merged commit 39e60f6 into master Apr 3, 2021
@marcus7070 marcus7070 deleted the coplanar-check branch April 5, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placing a Circle On Each Face of Cube and Extruding Results In Invalid Solid
3 participants