-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate alembic and add hg38 DB schema as initial revision #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor request to add a comment to the commented line.
tdp_publicdb/migration/versions/assets/ordino-schema-postgres12.sql
Outdated
Show resolved
Hide resolved
tdp_publicdb/migration/versions/20200302_1312_b477004c3673_First_Revision.py
Outdated
Show resolved
Hide resolved
Running the first alembic revision in an empty database produces the below error when querying the data. This error can be fixed by refreshing the view right after creating it: REFRESH MATERIALIZED VIEW cellline.mutationalburden; Source: scenic-views/scenic#184 |
The required PR datavisyn/tdp_core#292 was merged into the develop branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the integration and testing. I ran a test now and it works well. 👍
This PR depeneds on datavisyn/tdp_core#292
Closes #64
Summary
db-migration:upgrade:head:tdp_publicdb
both in a postgres 10-alpine container and and postgres 12.1 container. In both cases the schema gets imported and the tdp_publicdb_alembic_version table with the current revision ID gets created in the public schema.The following script to create the tdp_publicdb_alembic_version table needs to be executed in the hg_38 postgres 12.1 database so the alembic upgrade command does not try to upgrade it.
To test
Switch tdp_core branch to the--> merged into developmp/291_db_migration
(necessary since the alembic integration is not yet in the develop branch).postgres12.1
container and a matchingpgadmin
container in yourdocker-compose.yml
file.pgadmin
on the browser and add ordino and postgres users/roles.db-migration:upgrade:head:tdp_publicdb
.tdp_publicdb_alembic_version
has been created.