-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extension point to manage database migrations #292
Conversation
7653b28
to
7d8b3e4
Compare
7d8b3e4
to
2cca2d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your implementation and the good documentation! 👍 For me it works as described.
@puehringer Please add an according minor or major release label to the PR.
@lehnerchristian Please have a look if the implementation is fine for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. however I haven't tested it yet
After the demo yesterday I think we can merge. @thinkh you made some notes as far as I saw. do you want to copy them over? |
I did not take notes, since @puehringer rembembered the to dos. @puehringer Your turn. 😉 |
@thinkh Of course I remembered everything 😉 |
4e2ee7a
to
3d83fb6
Compare
@thinkh @lehnerchristian The two remaining issues are solved and documented in the wiki. This PR is therefore ready to merge. |
1e64239
to
c8740ae
Compare
c8740ae
to
7dad884
Compare
one thing I noticed in the docs: in https://wiki.datavisyn.io/tdp/extension-points/db-migration#initializing-the-migrations-folder you're updating the access rights for the new migration folder the command you use is however it should be |
@lehnerchristian I changed it to |
The required PR datavisyn/tdp_core#292 was merged into the develop branch.
Summary
This PR adds the ability to tightly integrate Alembic migrations into
tdp_core
applications.How it works
On startup, the
DBMigrationManager
retrieves all extension points with the keytdp-sql-database-migration
and creates aDBMigration
object for each them. This procedure is very similar to howDBConnector
are loaded. ADBMigration
then can execute all Alembic commands (upgrade
,downgrade
,history
,stamp
, ...) with all options within the context of a specific migration.How to use
The documentation moved to https://wiki.datavisyn.io/tdp/extension-points/db-migration