Switch to LineUp v4 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With LineUp 4 the `group.order` was changed from `number[]` to a `IndicesArray = (ReadonlyArray<number> | UIntTypedArray) & ArrayLike<number>;` In the RankingAdapter the group array was flatten to a `number[]`. Flatting is not possible with `Uint16Array`. Hence, we need to convert them with `Array.from()` to a `number[]`
# Conflicts: # src/RankingAdapter.ts # src/tasks/Tasks.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary changes that Tourdino works with LineUp v4.
Make sure to use the correct branch. Once datavisyn/tdp_core#377 is merged Tourdino requires the tdp_core
developbranch.