Switch to LineUp v4 #377
Merged
Switch to LineUp v4 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # src/lineup/ARankingView.ts
…roperty was removed for columns in lineupjs
# Conflicts: # package.json
# Conflicts: # src/styles/_view_lineup.scss
# Conflicts: # package.json # src/lineup/ARankingView.ts # src/lineup/internal/LineUpColors.ts
in the context of (un-)tracking LineUp actions
`rendererType` -> the function `getRendererType()` does not exist and therefore it has to be converted to 'getRenderer()'
and remove `console.log` comment
# Conflicts: # package.json
# Conflicts: # package.json
…syn/tdp_core into stoiber/lineup-v4-alpha12
…-events Ignore live preview events
Closes #365 Previously, the group height is set as hard-coded values and ignores the LineUp/Taggle default config values. This refactoring uses the taggle options (LineUp default config + ARankingView custom options). The event `LineUpPanelActions.EVENT_RULE_CHANGED` was removed and replaced with the `LineUpPanelActions.EVENT_TOGGLE_OVERVIEW` which simply returns a boolean. Afterwards the space-filling rule is only instanciated and used in ARankingView.
…height Fix group height in overview mode
Call itemRowHeight function also for groups
Since LineUp v4.0.0 is released https://github.com/lineupjs/lineupjs/releases/tag/v4.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges a couple of changes that were necessary to use LineUp v4.
Once LineUp v4 is available in the
developbranch, we must switch the dependency in the package.json (see lineupjs/lineupjs#331).