Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the overflow of the SidePanel to be compatible with lineup-v4 #356

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Change the overflow of the SidePanel to be compatible with lineup-v4 #356

merged 2 commits into from
Apr 23, 2020

Conversation

oltionchampari
Copy link
Contributor

Closes #354

Summary

  • Changed the overflow to be compatible with the lineupjs-v4 branch.

Screenshot

overflow_fixed

@oltionchampari oltionchampari added type: bug Something isn't working release: minor PR merge results in a new minor version labels Apr 21, 2020
thinkh
thinkh requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now for the LineUp side panel, but not for additional panels like the tourdino side panel.

grafik

grafik

Probably there is still some CSS property missing for the non-LineUp side panel classes. Could you please check again?

src/styles/_view_lineup.scss Outdated Show resolved Hide resolved
src/styles/_view_lineup.scss Outdated Show resolved Hide resolved
oltionchampari
oltionchampari commented Apr 22, 2020
View reviewed changes
src/styles/_view_lineup.scss
// Add scrollbar to SidePanel higher in the node tree
.lu-side-panel-main {
overflow-y: auto;
overflow-x: hidden;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add scrollbar in y-axis and hide it in the x-axis.

thinkh
thinkh approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works as expected.

@thinkh thinkh merged commit 7c0f14c into lineupjs4 Apr 23, 2020
@thinkh thinkh deleted the sidepanel_overflow_bug branch April 23, 2020 10:39
@thinkh thinkh mentioned this pull request Jun 15, 2020
Merged
@thinkh thinkh mentioned this pull request Jul 30, 2020
Merged
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

@lehnerchristian lehnerchristian Awaiting requested review from lehnerchristian

Assignees

@thinkh thinkh

Labels
release: minor PR merge results in a new minor version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oltionchampari @thinkh