Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LineUp CMD bug #358

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Fix LineUp CMD bug #358

merged 3 commits into from
Apr 23, 2020

Conversation

oltionchampari
Copy link
Contributor

Closes #357

Summary

  • Created an enum containing the cmds that originate from LineUp ( get triggered by clicking the LineUp UI).
  • Changed the implementation to close column dialogs only if the action is not a LineUp action.
  • Tested all actions and the solution works as expected and produces no apparent side effects.

Result:

correct_name

correct_state_1

correct_state_2

@oltionchampari oltionchampari added type: bug Something isn't working release: minor PR merge results in a new minor version labels Apr 22, 2020
@thinkh thinkh self-requested a review April 22, 2020 14:51
@thinkh thinkh changed the title Fix LineUp cmds bug Fix LineUp CMD bug Apr 23, 2020
thinkh
thinkh approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation and the fix. In my tests it works now.

@thinkh thinkh merged commit 2b1f406 into lineupjs4 Apr 23, 2020
@thinkh thinkh deleted the lineup_cmds_bug branch April 23, 2020 10:25
@oltionchampari oltionchampari mentioned this pull request Jun 9, 2020
Merged
@thinkh thinkh mentioned this pull request Jun 9, 2020
Closed
@oltionchampari oltionchampari mentioned this pull request Jun 9, 2020
Closed
@thinkh thinkh mentioned this pull request Jun 15, 2020
Merged
@thinkh thinkh mentioned this pull request Jul 30, 2020
Merged
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

@lehnerchristian lehnerchristian Awaiting requested review from lehnerchristian

Assignees

@thinkh thinkh

Labels
release: minor PR merge results in a new minor version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oltionchampari @thinkh