Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call itemRowHeight function also for groups #376

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Call itemRowHeight function also for groups #376

merged 1 commit into from
Jun 9, 2020

Conversation

lehnerchristian
Copy link

In this PR we also call the itemRowHeight function for groups and decide in the function what should be done

@lehnerchristian lehnerchristian requested a review from thinkh June 9, 2020 14:54
thinkh
thinkh approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine in my opinion. The application must adapt to the new function signature.

@thinkh thinkh merged commit 7ffa601 into lineupjs4 Jun 9, 2020
@thinkh thinkh deleted the clehner/lineupjs4 branch June 9, 2020 15:03
@thinkh thinkh mentioned this pull request Jun 15, 2020
Merged
@thinkh thinkh mentioned this pull request Jul 30, 2020
Merged
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehnerchristian @thinkh