Skip to content

Commit

Permalink
Merge pull request #376 from datavisyn/clehner/lineupjs4
Browse files Browse the repository at this point in the history
Call itemRowHeight function also for groups
  • Loading branch information
thinkh authored Jun 9, 2020
2 parents 642b587 + 406c4c3 commit 7ffa601
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/lineup/ARankingView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export interface IARankingViewOptions {
*/
enableStripedBackground: boolean;

itemRowHeight: number | ((item: IGroupItem) => number) | null;
itemRowHeight: number | ((item: IGroupItem | IGroupData) => number) | null;

customOptions: Partial<ITaggleOptions>;
customProviderOptions: Partial<ILocalDataProviderOptions & IDataProviderOptions & { maxNestedSortingCriteria: number; maxGroupColumns: number; filterGlobally: true; }>;
Expand Down Expand Up @@ -281,7 +281,7 @@ export abstract class ARankingView extends AView {
defaultHeight: taggleOptions.rowHeight,
padding: () => 0,
height: (item: IGroupItem | IGroupData) => {
return isGroup(item) ? taggleOptions.groupHeight : f(item);
return f(item) ?? (isGroup(item) ? taggleOptions.groupHeight : taggleOptions.rowHeight);
}
});
}
Expand Down

0 comments on commit 7ffa601

Please sign in to comment.