DIG-1247: Check that submitter_specimen_id refers to a valid specimen #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavyx
reviewed
Aug 17, 2023
| @@ -24,7 +24,7 @@ def __str__(self): | |||
| def warn(message): | |||
| message = ">".join(STACK_LOCATION) + ": " + message | |||
| VALIDATION_MESSAGES.append(f"{message}") | |||
| raise MoHValidationError(message) | |||
| #raise MoHValidationError(message) | |||
There was a problem hiding this comment.
Should this be commented out?
There was a problem hiding this comment.
Yeah, I think it would be better to collate the warnings together and report them at the end, rather than error out when you reach any of them.
yavyx
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is included in pytest: test_data_ingest > test_donor_6. I also fixed a few default mappings for moh_template.csv and fixed a typo.