Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Toggle class visibility, legend class border and wms stack icon #2567

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jolevesq
Copy link
Member

@jolevesq jolevesq commented Oct 25, 2024

Closes #2550, #2564 , #2556

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Fix the border for class visibility in legend panel. Remove the one on layer and reverse color on class items
  • Fix the confusing label name for the toggle all class visibility in layers panel
  • Fix the inconsistency between WMS legend stack item

Fixes #2550, #2564, #2556

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Hosted October 25th, 4pm

https://jolevesq.github.io/geoview/demos-navigator.html?config=./configs/navigator/19-geojson.json

  • 2556
    • Open layers panel, click on Polygons
    • See the new label and divider
  • 2564
    • Open legend
    • See the dark border for visible class and light border for non visible (no more border for layers

https://jolevesq.github.io/geoview/demos-navigator.html?config=./configs/navigator/14-wms-layer.json

  • Open legend and layers to compare icon stack and see permanent snow and ice is now the same on both. Layers was wrong
  • Add this uuid to see it as well 1130248f-f1a3-4956-8b2e-38d29d3e4af7

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@jolevesq jolevesq requested a review from DamonU2 October 25, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Legend image icon ratio is not respected for WMS layers in the Layers tab.
1 participant