Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For a symlink to another partition, opening it in a new panel shows a wrong fs size #804

Closed
jinliu opened this issue Nov 30, 2023 · 6 comments · Fixed by #805
Closed

For a symlink to another partition, opening it in a new panel shows a wrong fs size #804

jinliu opened this issue Nov 30, 2023 · 6 comments · Fixed by #805
Labels
bug Something isn't working

Comments

@jinliu
Copy link
Contributor

jinliu commented Nov 30, 2023

STEPS TO REPRODUCE:

  1. Create a symlink to a dir in another partition.
  2. broot --show-root-fs
  3. Press right on that link.
  4. The fs size on the header bar updates correctly.
  5. Press left to go back.
  6. Press Ctrl+right to open the symlink in a new panel.
  7. The fs size in the new panel is still that of the left panel.
@jinliu jinliu added the bug Something isn't working label Nov 30, 2023
@jinliu
Copy link
Contributor Author

jinliu commented Nov 30, 2023

Perhaps one solution is to make ctrl-right behave like right: the current directory is set to the target of the symlink, not the symlink itself. More consistency.

@Canop
Copy link
Owner

Canop commented Nov 30, 2023

I reproduce the problem. I'll have a look.

Canop added a commit that referenced this issue Nov 30, 2023
@Canop
Copy link
Owner

Canop commented Nov 30, 2023

It should be fixed by #805

@jinliu
Copy link
Contributor Author

jinliu commented Nov 30, 2023

Yes, it works. Thanks!

@Canop
Copy link
Owner

Canop commented Nov 30, 2023

BTW I'll push another change, I think: removing the filter when doing :panel_right on a directory

Canop added a commit that referenced this issue Nov 30, 2023
@alexn-s
Copy link

alexn-s commented Dec 21, 2023

i think this fix or at least version 1.30.0 > breaks something on windows @Canop .
the right/ second panel is broken and commands like cpp and mvp wont work.

the path is not correct

version 1.30.0, 1.30.1

image

version 1.29.0

image

sys info

OS: Windows 11 Home x86_64
Terminal: Windows Terminal
shell: nushell

let me know if i can provide more information

Canop added a commit that referenced this issue Dec 22, 2023
Fix #809

It's thus possible that issue #804 exists on Windows, I can't test that.
Canop added a commit that referenced this issue Dec 22, 2023
Fix #809

It's thus possible that issue #804 exists on Windows, I can't test that.
JonasLeonhard pushed a commit to JonasLeonhard/broot that referenced this issue Jan 11, 2024
Fix Canop#809

It's thus possible that issue Canop#804 exists on Windows, I can't test that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants