Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I need testers - please register #182

Open
Canop opened this issue Jan 25, 2020 · 62 comments
Open

I need testers - please register #182

Canop opened this issue Jan 25, 2020 · 62 comments
Labels
help wanted Extra attention is needed

Comments

@Canop
Copy link
Owner

Canop commented Jan 25, 2020

I need testers to avoid distributing broken new versions, to tune and improve new features, and to ensure there's no regression, especially on platforms I can't test on.

To test, you need:

  • to know your way in git in order to fetch from upstream or change branches
  • to be able to compile from source
  • to be able to come to the chat (https://miaou.dystroy.org/3)

If you're willing to help, please answer with your platform, watch this issue, and, on announcements if you have the time, test and tell me in the chat if it's OK or not, or what should be fixed or improved.
If people answer here, I'll announce the dangerous commits or branches in this issue.

@Canop Canop pinned this issue Jan 25, 2020
@Canop
Copy link
Owner Author

Canop commented Jan 26, 2020

Right now I'd need people to test the git branch.
image

@Canop Canop added the help wanted Extra attention is needed label Jan 26, 2020
@joepio
Copy link

joepio commented Jan 27, 2020

I'm in! Installed the git branch. My setup:

  • Machine: Macbook Pro 16' 2019
  • OS: MacOS Catalina (10.15.1, will keep it updated)
  • Terminal: iTerm2 3.3.7
  • ShelL: ZSH (5.7.1) + OhMyZSH

@sigfriedmcwild
Copy link

I'm not a heavy user, but I can try to help

  • Os: Windows 10

@Canop
Copy link
Owner Author

Canop commented Jan 27, 2020

I just pushed a testable version on the "git" branch. The main changes are

  • leveraging libgit2 to handle finding what files to ignore (mostly to handle corner cases like the global .gitignore)
  • simplifying the git_ignore toggle to only 2 states

I'm a little disappointed by the slowness of libgit2. I'd be interested by your feeling, maybe your speed comparisons. And as the compilation is a little more complicated, I'd like a confirmation there's no problem when compiling directly on mac or windows.

@Canop
Copy link
Owner Author

Canop commented Jan 28, 2020

I changed a lot of things in the git ignoring system. I'd like to have confirmation everything looks OK.

@pierd
Copy link

pierd commented Jan 29, 2020

I can also help:

  • Machine: MacBook Pro (15-inch, 2018)
  • OS: MacOS Mojave (10.14.6)
  • Terminal: iTerm2 (3.3.7) + Terminal (2.9.5)
  • Shell: ZSH (5.3)

If needed I can also boot Windows 10 on the same machine.

@Canop
Copy link
Owner Author

Canop commented Jan 29, 2020

Question to testers: what should in your opinion be the value of the git status display toggle ? Should the status display be enabled by default ?

@pierd
Copy link

pierd commented Jan 29, 2020

Personally I don't see much value in this feature (as in I wouldn't really use it). Since I have all my repositories in one directory, I would rather use some special mode that would show this information in a separate column (like --sizes).

BTW I tried using it with some big repositories and I've noticed that it blocks - there's a noticeable pause when entering them. Version built from master doesn't have this problem.

@Canop
Copy link
Owner Author

Canop commented Jan 30, 2020

I pushed a new commit which makes the git_file_info not the default but also add more measurement points. I'd appreciate to have the DEBUG mode log of broot when it pauses entering a big repository so that I can see what exactly is slow (and maybe run this operation in a background thread).

@pierd
Copy link

pierd commented Jan 30, 2020

Ok, I gave it a go with entering https://github.com/torvalds/linux in case you would like to test locally (previously I was testing on some private repos that I can't share). My test:

  1. Run broot providing directory containing 2 repos: broot and linux kernel.
  2. Go down to linux kernel repo.
  3. Enter it.
  4. Quit with :q.

First run is with a simple build from your branch (git), here are the logs:
no-git-dev.log

Second with turning on show_git_file_info in code:

diff --git a/src/tree_options.rs b/src/tree_options.rs
index 77b0f5f..c5ee013 100644
--- a/src/tree_options.rs
+++ b/src/tree_options.rs
@@ -62,7 +62,7 @@ impl Default for TreeOptions {
             only_folders: false,
             show_sizes: false,
             show_dates: false,
-            show_git_file_info: false,
+            show_git_file_info: true,
             trim_root: true,
             show_permissions: false,
             respect_git_ignore: true,

Logs:
git-dev.log

I think these 2 are the culprits:

20:52:23 [DEBUG] (1) broot::git_status: get diff and stats took 1.600527973s
20:52:28 [DEBUG] (1) broot::tree_build::builder: computing git file infos took 7.419583807s

@Canop
Copy link
Owner Author

Canop commented Feb 3, 2020

I've merged the git branch into master.
But now the git stats computation is done in a background thread and doesn't slow navigation or display.
Git information aren't displayed by default: the :gf toggle must be used

@Canop
Copy link
Owner Author

Canop commented Apr 8, 2020

I just published the 0.13.6 version which ignores diacritics when searching. As the impact may be important, I'd be happy to hear from users on this one (here or on https://miaou.dystroy.org/3)

@Canop
Copy link
Owner Author

Canop commented May 17, 2020

I just merged the "panels" branch into master. The feature still needs more work but it starts to be usable (and the rest works as before).
I'd really like to have some reactions to this whole set of features.
I created an issue for that ( #230 ) but the initial discussion could also occur on miaou.
As I rewrote most of broot, it's very possible there were regressions, please tell me if you found one.

@Canop
Copy link
Owner Author

Canop commented Jun 4, 2020

The new-pattern branch is still a work in progress but is testable and I'd welcome opinions.

In short it introduce a new pattern syntax (with a breaking change) and a few new capabilities.

With the default settings, here's how you search:

name exemple query example match explanation
fuzzy name abc abac.txt search for "abc" in a fuzzy way in filenames
regex name /abc abc.txt search for the regular expression abc in filenames ("exact search")
regex name /[yz]{3} fuzzy.rs search for the regular expression [yz]{3} in filenames
regex name /abc/i aBc.txt search for the regular expression abc with flag i in filenames
fuzzy path p/abc a/bac.txt search for "abc" in a fuzzy way in sub-paths from root
regex path rp/abc e/abac.txt search for the "abc" regex in sub-paths from root

(other types of search should come)

The search syntax is thus globally

<mode><pattern>[/<flags>]

(a verb invocation can follow as before)

The mode is either nothing (fuzzy name), just a slash (regex name) or some letters followed by a slash.

It's also possible to redefine the mode mappings if you want, for example if you usually prefer to do exact searches:

[search-modes]
"<empty>" = "regex name"
"/" = "fuzzy path"
"z/" = "regex path"

I said this was a breaking change because I can no longer decide a search is a regex just because it finishes by a /. abc/ is no longer a regex search. I have pondered alternative syntaxes (some in issues) but none was natural or easy to explain enough while the / character is frequently used for searches.

@Canop
Copy link
Owner Author

Canop commented Jun 12, 2020

I just released broot 0.15.0

One of the interesting new features is the search on file content (prefix the pattern with c/).

It looks like this full text search is quite fast on linux but I'd be interested in confirmations (or infirmations). For a comparison with other full text search tools it's possible to run commands like

time br -c "c/memmap;:pp"

or

time br -c "c/memmap;:total_search;:pt"

(the second one to get all matching files)

@Canop
Copy link
Owner Author

Canop commented Jun 26, 2020

Broot looks complete to me. If no problem is found I might label the 0.18 as 1.0 in a few days.

@Canop
Copy link
Owner Author

Canop commented Jul 13, 2020

There's currently a new branch: preview_panel.
When in this branch, if you do ctrl-right when a file is selected, you get a synchronized preview panel

image

It's still a preliminary version. It's not yet time for you to test but if you're interested you might come and chat

@Lucretiel
Copy link
Contributor

I can test on Windows (both powershell and WSL) and, in about a month, on Mac

@asdf8dfafjk
Copy link
Contributor

I made an automated testing script here, check it out - https://github.com/asdf8dfafjk/broot_testing

@Canop
Copy link
Owner Author

Canop commented Aug 20, 2020

Since version 0.20.0, broot is in release candidate mode, meaning I'm only fixing bugs (when I found some) and not adding any feature. When I feel confident enough, I'll tag the current version as 1.0.

@Canop
Copy link
Owner Author

Canop commented Sep 9, 2020

The "clipboard" feature, which must be activated at compilation, brings two verbs:

  • :input_paste, mapped to ctrl-v, which inserts the clipboard content into the input
  • :copy_path, mapped to alt-c, which puts the selected path in the clipboard

I'd need dev and user feedback regarding the compilation on your platform and your user experience.

@Lucretiel
Copy link
Contributor

Just tested it; ran into build trouble. Can you recommend which xcb libraries to install specifically? There's no libxcb (at least not in apt), and it wasn't clear which other ones to pick.

@Stargateur
Copy link
Contributor

https://github.com/aweinstock314/rust-clipboard => sudo apt-get install xorg-dev

@Lucretiel
Copy link
Contributor

Ah, thank you; I dug too deep too quickly in the dependency tree.

@Canop
Copy link
Owner Author

Canop commented Sep 10, 2020

Well, that's still useful: I must document that building on linux involves this step. And it means it will be harder to incorporate this feature in an application that people expect to install with cargo.

@Lucretiel
Copy link
Contributor

Lucretiel commented Sep 10, 2020

I also needed to install:

libxcb-render0-dev
libxcb-shape0-dev
libxcb-xfixes0-dev

Additionally, I played around with it some more and I believe that xorg-dev is not fully needed, but it brings in libxcb1-dev, which fills the -lxcb requirement. So the actual list* is:

libxcb1-dev
libxcb-render0-dev
libxcb-shape0-dev
libxcb-xfixes0-dev

* at least, on my Ubuntu instance, using apt. Other package managers might have different names.

@levone1
Copy link

levone1 commented Dec 16, 2021

I'm having an issue with installation which I think ties in to what's here, (although I'm not clear on it).

I'm using SailfishOS, ans have cargo/rust installed normally through instructions on "Install Rust" page. Have used it to build and install many packages, including Broot 1.6. However, when I attempt to install newer version, I get build failure, whether doing it through "cargo install" or downloading code and trying "cargo build". The output is very long, (I'll post if you want), but what I get out of it is something to do with lxcb.

There is no X-support for native SailfishOS, so none of the X packages have ever been installed on my device, but broot built, installed, and ran fine, until latest version.

Is there different deps in new version, or is this something I could probably work around?

Thanks

@Canop
Copy link
Owner Author

Canop commented Dec 16, 2021

@levone1 I'm currently discussing with another user in the chat having a probably similar failure.

I've created a new issue : #468

@levone1
Copy link

levone1 commented Dec 16, 2021

@levone1 I'm currently discussing with another user in the chat having a probably similar failure.

I've created a new issue : #468

Ok. I'll stay tuned there, and post details... One note is that I installed on Linux Mint with no problem, using "cargo install". But, obviously, there are all X dependencies there, so....

@Canop
Copy link
Owner Author

Canop commented Dec 16, 2021

I'll probably release a new version making the clipboard feature non default again. Even for people with X11 it makes compilation harder due to more dependencies.

@joao-aguirre
Copy link

Hello!

I am using Broot on Windows and Linux and I would be happy in helping with testing.

On Windows 10, I am using the Windows Terminal but running Cmder (providing clink), sometimes cmd, sometimes PowerShell.

On Linux, I am using Oracle Linux 8.6 via WSL, with bash as my sell via Windows Terminal.

I'll keep an eye on this issue and try to help as I can.

Cheers.

@Canop
Copy link
Owner Author

Canop commented Jul 18, 2022

Thanks @joao-aguirre

If you're a developer, there's this issue which might be approachable: #575
I managed to do it for linux, mac & some other unixes, but it needs more than just tests for windows.

@Canop
Copy link
Owner Author

Canop commented Oct 4, 2022

The current version on master changes escaping rules, making it less necessary to escape charact'ers.

See incoming documentation at https://dystroy.org/broot-master/input/

I'd like people to try various patterns and inputs, especially the ones they'll probably use naturally, and report on ease and comfort.

@Canop
Copy link
Owner Author

Canop commented Oct 4, 2022

Also waiting for opinions on this: #611

@Canop
Copy link
Owner Author

Canop commented Jan 1, 2023

Nushell users, please have a look at #647

@Canop
Copy link
Owner Author

Canop commented Jan 12, 2023

Nushell users (again), please have a look at #649

@jinliu
Copy link
Contributor

jinliu commented May 16, 2023

Glad to help:
Archlinux
KDE, Konsole/Yakuake
fish shell

@Canop
Copy link
Owner Author

Canop commented May 17, 2023

Tests welcome for #706

@Ckln
Copy link

Ckln commented Aug 28, 2023

Might want to help:
OS WSL2: Debian over Win 10
MobaXterm as terminal, bash as my shell

@Canop
Copy link
Owner Author

Canop commented Oct 19, 2023

I'd welcome tests of this PR: #769

It makes it possible to use the 'enter' key to open text files in your favourite text editor in the same terminal, instead of having a dedicated shortcut.

@Canop
Copy link
Owner Author

Canop commented Nov 12, 2023

Powershell users, can you have a look at this ? #793

@Canop
Copy link
Owner Author

Canop commented Nov 17, 2023

Tests of #798 welcome.

It allows keeping in sync the terminal's title, with a configurable pattern.

(to be honest I'm not sure it may really slow down some systems)

@Canop
Copy link
Owner Author

Canop commented Nov 29, 2023

I'd welcome tests of the new :trash internal on various systems: #803

@Canop
Copy link
Owner Author

Canop commented Dec 22, 2023

I'd like testers on Windows for #810

And issue #804 might need attention from same testers: does the problem exist on Windows ?

@Canop
Copy link
Owner Author

Canop commented Jan 18, 2024

Here's a PR which changes too many things internally to no risk breaking some of them: #826

So I'd need people to test it on as many terminals, systems, and workflows as possible.

@Daverd-GM
Copy link

Powershell users, can you have a look at this ? #793

I'm new to this. How can I help?

@Canop
Copy link
Owner Author

Canop commented Feb 2, 2024

@Daverd-GM The goal is to test this PR and check whether it fixes the mentioned problem.

It's quite easy if you know how to fetch a github branch and compile a rust program.
If you don't know how, please come tomorrow to the broot chat and either I'll tell you how to proceed or I'll compile the branch for you and put it at your disposal.

@Canop
Copy link
Owner Author

Canop commented Feb 10, 2024

People interested in having icons in broot should have a look at #333 (comment)
Detailed feedback welcome (even to say it's OK)

@Canop
Copy link
Owner Author

Canop commented May 1, 2024

Tests of #874 welcome

@Canop
Copy link
Owner Author

Canop commented May 27, 2024

I'd like people to test the new trash related features in #882

@Canop
Copy link
Owner Author

Canop commented Jun 26, 2024

Nushell users, can I have your opinion and test feedback on #891 ?

@yerlaser
Copy link
Contributor

Nushell users, can I have your opinion and test feedback on #891 ?

Thanks!
Just one remark, the overall change of temp folder is valid for all Linux and WSL.
I will later try to do the same changes in Bash/Zsh/Fish as well.

@Canop
Copy link
Owner Author

Canop commented Jul 6, 2024

I'd like testers for preview transformers, a new major feature of broot

@Canop
Copy link
Owner Author

Canop commented Jul 20, 2024

I'd really like opinions and test feedback on this one: #909

@Canop
Copy link
Owner Author

Canop commented Aug 1, 2024

I'm preparing a PR allowing resizing panels: #921

Discussion very welcome, especially if you see the need for other mechanisms (I'm probably not going to add mouse resizing, as it would require a visible separator)

@Canop
Copy link
Owner Author

Canop commented Aug 2, 2024

Anybody with knowledge of Powershell to check #913 and #912 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests