Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_again internal #909

Merged
merged 1 commit into from
Jul 25, 2024
Merged

search_again internal #909

merged 1 commit into from
Jul 25, 2024

Conversation

Canop
Copy link
Owner

@Canop Canop commented Jul 20, 2024

This brings the search_again internal, which tries to fix a frequent annoyance, which is the loss of the search pattern when navigating, something I hadn't found good ergonomics for before.

:search_again is mapped by default to ctrl-s.

  • When there's already an active filtering, and it wasn't complete, make it total (it thus does what the total_search internal was doing).
  • When there's no active filtering, brings back the last used.

Main use case: you search, have a lot of matches, focus a folder to look inside, then you can bring back the search pattern with ctrl-s.

I'd be very interested in tester feedback on this.

@FrancescElies
Copy link
Contributor

Shortly tried on a mac, it felt good to be able to bring back the previous search with ctrl-s.

Screen.Recording.2024-07-22.at.09.22.25.mov

Not sure if it's a better binding, but did you consider ctrl-r as a default? This would remind me of the reverse search in the shell.
On the other hand I find the double behaviour of ctrl-s for full search and bring back last search pretty good too and makes me happy the way it is.

@Canop Canop merged commit 85b4400 into main Jul 25, 2024
1 check passed
@Canop Canop deleted the search-again branch July 25, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants