Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python sdist issues #1708

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Fix Python sdist issues #1708

merged 4 commits into from
Jun 12, 2024

Conversation

speth
Copy link
Member

@speth speth commented Jun 11, 2024

Changes proposed in this pull request

  • Fix installation of YAML data files in the Python sdist
  • Simplify command line interface for building the sdist
  • Speed up CI by using micromamba
  • Remove test code from coverage report to avoid inflating apparent coverage

If applicable, fill in the issue number this pull request is fixing

Resolves #1678.

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

speth added 2 commits June 11, 2024 11:14
This was broken by the removal of the build/data directory in Cantera#1689.
Eliminates the confusing "python_sdist=yes" option

Resolves Cantera#1678
@speth speth force-pushed the fix-1678 branch 2 times, most recently from 2b1b2c7 to e66addb Compare June 11, 2024 17:44
@speth speth marked this pull request as ready for review June 11, 2024 18:14
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.82%. Comparing base (4565a55) to head (e0654b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
- Coverage   75.72%   72.82%   -2.90%     
==========================================
  Files         443      379      -64     
  Lines       60981    53592    -7389     
  Branches     9557     9122     -435     
==========================================
- Hits        46178    39031    -7147     
+ Misses      11777    11610     -167     
+ Partials     3026     2951      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speth speth merged commit 9f48b07 into Cantera:main Jun 12, 2024
45 of 47 checks passed
@speth speth deleted the fix-1678 branch June 12, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error trying to build Cantera with option python_sdist="yes"
2 participants