Truncate files when generating test data #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constantinpape
force-pushed
the
fix-tests
branch
from
80a8016 to
265d6f7
Compare
Also pin z5py version compatible with zarr-n5
constantinpape
force-pushed
the
fix-tests
branch
from
265d6f7 to
aa705fd
Compare
|
I fixed the issues in z5 and pinned to the new version here, now the tests pass. |
|
@Carreau, can you merge this por favor? |
|
Oops, sorry, I missed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Carreau,
I looked into this and the test failure was caused by not truncating the files in
generate_z5py.I fixed it (and also added a truncate in
generate_zarr).Note that there will probably still be a test failure because
z5pycan't read n5 files generated byzarr.I finally figured out that this is because zarr not truncating overhanging chunks; I am trying to fix this in z5py now.