Test using zarr-dev to potentially catch regressions. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Carreau
commented
Dec 3, 2020
Carreau
commented
Dec 3, 2020
joshmoore
reviewed
Dec 4, 2020
There was a problem hiding this comment.
Thanks for working on this @Carreau!
I am not quite sure why I called the kwarg for blosc filter_id.
I think it should be called cname, see https://github.com/zarr-developers/numcodecs/blob/master/numcodecs/blosc.pyx#L546.
Could you try changing it to cname and see if it fixes the issue in the test?
Also pin z5py version compatible with zarr-n5
|
Once Carreau#2 is merged the tests should all pass and we can merge this one :). |
|
@constantinpape : awesome sauce! |
|
@constantinpape : |
Truncate files when generating test data
constantinpape
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.