Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstream repositories, on which we should test zarr/master #668

Closed
4 tasks done
Carreau opened this issue Dec 2, 2020 · 11 comments
Closed
4 tasks done

Downstream repositories, on which we should test zarr/master #668

Carreau opened this issue Dec 2, 2020 · 11 comments

Comments

@jakirkham
Copy link
Member

cc @rabernat @joshmoore

@jakirkham
Copy link
Member

cc @constantinpape

@jakirkham
Copy link
Member

For context, we are considering changes like PR ( #612 ), which wouldn't expect to cause issues for downstream, but it would be nice to confirm that somehow. Either by testing here or testing on the downstream repos themselves.

@jhamman
Copy link
Member

jhamman commented Dec 2, 2020

FWIW, Xarray has recently added a nightly ci build that includes zarr-master (example).

@rabernat
Copy link
Contributor

rabernat commented Dec 2, 2020

One idea would be to have a dedicated integration test repo for zarr, xarray, dask, and fsspec that would help cover the many edge cases that arise when these libraries all interact.

@jakirkham
Copy link
Member

cc @martindurant

@martindurant
Copy link
Member

Some downstreams (fsspec/s3fs) are tested directly in zarr's suite. Similarly, some combinations of dask/xarray are already tested in places, including their own repos.
It's fairly typical to see CI runs that install a variety of "dev" packages from the source repos.

Testing a workflow that touches all of the parts is tricky, and unlikely to catch the corner cases that arise in real work. For example, many s3 problems are around real cluster use and auth, which is very hard to test against. rechunker I suppose uses everything, but what range of likely usage patterns does it cover?

@Carreau
Copy link
Contributor Author

Carreau commented Dec 2, 2020

FWIW, Xarray has recently added a nightly ci build that includes zarr-master (example).

Good; so we are confident that if something break upstream, a bug will be fixed fast :-)

@joshmoore
Copy link
Member

#668 (comment) One idea would be to have a dedicated integration test repo for zarr, xarray, dask, and fsspec...

I don't have an immediate driver for xarray, but I was certainly considering adding to @constantinpape's zarr_implementations for example different versions & at least a few different cloud backends. If such a test suite appears elsewhere, though, happy to adapt.

@jrbourbeau
Copy link
Member

We added Zarr master to Dask's upstream CI build in dask/dask#6932

@Carreau
Copy link
Contributor Author

Carreau commented Dec 4, 2020

Awesome !

@jhamman jhamman closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants