Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "roaming" option to run conditions #177

Closed
balihb opened this issue Jan 2, 2019 · 7 comments · Fixed by #441
Closed

Add "roaming" option to run conditions #177

balihb opened this issue Jan 2, 2019 · 7 comments · Fixed by #441
Assignees
@Catfriend1
Labels
enhancement
Milestone
1.2.1

Comments

@balihb
Copy link

balihb commented Jan 2, 2019

adding roaming as run condition would be a nice addition. lots of people have limited data when roaming.
@Catfriend1
Copy link
Owner

Good idea!

@Catfriend1 Catfriend1 changed the title roaming mobil data as run condition Run Conditions - Add roaming below mobil data Jan 2, 2019
@Catfriend1 Catfriend1 changed the title Run Conditions - Add roaming below mobil data Run Conditions - Add roaming below mobile data Jan 3, 2019
@Catfriend1 Catfriend1 mentioned this issue Jan 3, 2019
Closed
@Catfriend1
Copy link
Owner

I'm planning to implement this after #110

@Catfriend1
Copy link
Owner

Maybe we'll do this earlier and then rework the run conditions...

@Catfriend1
Copy link
Owner

Ahh yes, already March and I didn't get my ass up to do this. Maybe I should make that earlier than originally intended.

@Catfriend1
Copy link
Owner

Ahh yes, already July and I didn't get my ass up to do this. Maybe I should make that earlier than originally intended.

Catfriend1 added a commit that referenced this issue Jul 11, 2019
@Catfriend1
UI: Add "roaming" run condition
d420fd0 
ref: #177
@Catfriend1 Catfriend1 self-assigned this Jul 11, 2019
@Catfriend1 Catfriend1 added this to the 1.2.1 milestone Jul 11, 2019
Catfriend1 added a commit that referenced this issue Jul 11, 2019
@Catfriend1
Handle roaming state in RunConditionMonitor (fixes #177)
0550c87
@Catfriend1 Catfriend1 mentioned this issue Jul 11, 2019
Merged
@Catfriend1 Catfriend1 changed the title Run Conditions - Add roaming below mobile data Add "roaming" option to run conditions Jul 11, 2019
@Catfriend1
Copy link
Owner

Inspired by: syncthing/syncthing-android#458 (comment) @jangrewe

Catfriend1 pushed a commit that referenced this issue Jul 11, 2019
Add "roaming" option to run conditions (fixes #177) (#441)
bf161ec 
* UI: Add "roaming" run condition

ref: #177

* Settings UI: Add "roaming" run condition

* Update strings.xml

* Handle roaming state in RunConditionMonitor (fixes #177)

* Add "feedback required" notice

* Update strings.xml

* Imported de translation
@Catfriend1
Copy link
Owner

A new release is up @ https://github.com/Catfriend1/syncthing-android/releases/tag/rc1.2.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Catfriend1 Catfriend1

Labels
enhancement
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

Add "roaming" option to run conditions (fixes #177) Catfriend1/syncthing-android
2 participants
@balihb @Catfriend1