Only start syncthing native when at least one folder or device is/would be unpaused #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only apply custom per-object run conditions when syncthing is running or should run. Don't evaluate the paused states when syncthing is not running as it's useless.
Requires UnixTools sed.exe on Windows
- Remove duplicate log lines referring to the same logic that happened - Improved log levels
Remove hack to initially broadcast service State.DISABLED
/**
* Reads ConfigXml, returns true if at least one object will unpause
* when the syncting native would be started after this check.
* This checks both objects with "...CustomSyncConditionsEnabled == [true|false]"
* Objects with "...CustomSyncConditionsEnabled == false" are controlled manually by the user.
*/
…ld be unpaused (fixes #189)
…Unpause "A folder cannot sync unpaused when all devices are paused"
Catfriend1
added
the
testing
|
This damn PR got stuck in the shaft of the gun... |
Catfriend1
added
invalid
and removed
enhancement
testing
|
It is NOT COMPLETE and it WILL NOT be complete in the near future. So I'm dropping this.
|
Catfriend1
changed the title
This was referenced Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Rework custom run conditions
Related issues:
#177 - Run Conditions - Add roaming below mobile data
#110 - Enhancement request for per-folder(device) sync conditions
#189 - Only start syncthing native when at least one folder or device is/would be unpaused
#190 - Logical fail: (Un)pause a folder with individual run conditions set is undone
#191 - Always run syncthing when connected to WiFi in a fresh setup with no devices in the config yet
Testing:
In progress ...