Add Pkpass parser #2038
Draft
Add Pkpass parser #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theimpulson
reviewed
Aug 18, 2024
theimpulson
reviewed
Aug 18, 2024
TheLastProject
force-pushed
the
feature/pkpass2024
branch
4 times, most recently
from
7124d28
to
657807c
Compare
TheLastProject
force-pushed
the
feature/pkpass2024
branch
7 times, most recently
from
562d9d1
to
72fb68f
Compare
TheLastProject
force-pushed
the
feature/pkpass2024
branch
3 times, most recently
from
1a9755e
to
2150e2a
Compare
TheLastProject
force-pushed
the
feature/pkpass2024
branch
from
2150e2a
to
6eaf23e
Compare
TheLastProject
force-pushed
the
feature/pkpass2024
branch
4 times, most recently
from
a78acad
to
9362482
Compare
TheLastProject
force-pushed
the
feature/pkpass2024
branch
7 times, most recently
from
4eb7e68
to
936bbb8
Compare
TheLastProject
force-pushed
the
feature/pkpass2024
branch
2 times, most recently
from
1aed1de
to
110fa53
Compare
TheLastProject
force-pushed
the
feature/pkpass2024
branch
from
110fa53
to
aa9ba75
Compare
When you turn a LoyaltyCard into a bundle, it writes the files to storage as it can't otherwise fit in the limited storage size. This means that, on rotation, you write all images to storage and load them again. Using a ViewModel prevents that storage hit due to holding it in memory (as a ViewModel has a longer lifecycle).
This should make it possible to properly cancel the running barcode generation threads on rotation and prevent CPU rising on many rotations.
TheLastProject
force-pushed
the
feature/pkpass2024
branch
2 times, most recently
from
1518932
to
fe770c8
Compare
This prevents loading the front and back images when scrolling through the loyalty card list and should allow scaling to more images/files more easily
TheLastProject
force-pushed
the
feature/pkpass2024
branch
from
fe770c8
to
6668338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! Blocked by #2051 !!!
New regression to fix: