-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pkpass parser #2038
Draft
TheLastProject
wants to merge
10
commits into
main
Choose a base branch
from
feature/pkpass2024
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Pkpass parser #2038
Commits on Nov 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e2aead5 - Browse repository at this point
Copy the full SHA e2aead5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 798d969 - Browse repository at this point
Copy the full SHA 798d969View commit details -
Configuration menu - View commit details
-
Copy full SHA for c477da7 - Browse repository at this point
Copy the full SHA c477da7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fee6918 - Browse repository at this point
Copy the full SHA fee6918View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba343d8 - Browse repository at this point
Copy the full SHA ba343d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for acbee46 - Browse repository at this point
Copy the full SHA acbee46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98577ef - Browse repository at this point
Copy the full SHA 98577efView commit details -
Use ViewModel to prevent hammering storage
When you turn a LoyaltyCard into a bundle, it writes the files to storage as it can't otherwise fit in the limited storage size. This means that, on rotation, you write all images to storage and load them again. Using a ViewModel prevents that storage hit due to holding it in memory (as a ViewModel has a longer lifecycle).
Configuration menu - View commit details
-
Copy full SHA for 4d3dc06 - Browse repository at this point
Copy the full SHA 4d3dc06View commit details -
This should make it possible to properly cancel the running barcode generation threads on rotation and prevent CPU rising on many rotations.
Configuration menu - View commit details
-
Copy full SHA for 0f196b9 - Browse repository at this point
Copy the full SHA 0f196b9View commit details
Commits on Dec 1, 2024
-
This prevents loading the front and back images when scrolling through the loyalty card list and should allow scaling to more images/files more easily
Configuration menu - View commit details
-
Copy full SHA for 6668338 - Browse repository at this point
Copy the full SHA 6668338View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.