1.18 improvement - migrate to stability metrics framework #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes/kubernetes@b9c7007 mikedanese, Jul 9, 2019
kubernetes/kubernetes@f55efb8 lavalamp, Jul 21, 2019
(structured-merge-diff) kubernetes/kubernetes@3c81a9a lavalamp, Jul 21, 2019 # Conflicts: # go.mod # go.sum # staging/src/k8s.io/apiextensions-apiserver/go.sum # staging/src/k8s.io/apiserver/go.mod # staging/src/k8s.io/apiserver/go.sum # staging/src/k8s.io/kube-aggregator/go.sum # staging/src/k8s.io/legacy-cloud-providers/go.sum # staging/src/k8s.io/sample-apiserver/go.sum # vendor/modules.txt # vendor/sigs.k8s.io/structured-merge-diff/value/value.go
kubernetes/kubernetes@a42e029 mikedanese, Aug 20, 2019
kubernetes/kubernetes@099484e zshihang, Aug 19, 2019 Change-Id: Iacab685a710d8f8d5b80ed0d35e5ccc22bd929cb
kubernetes/kubernetes@a101acc dependency of 81173 BenTheElder, Jun 27, 2019
kubernetes/kubernetes@9b4b509 BenTheElder, Jun 27, 2019 dependency of 81173
kubernetes/kubernetes@59c4eb2 BenTheElder, Jun 27, 2019 dependency of 81173 # Conflicts: # hack/.shellcheck_failures
…apVolumeFunc for csi migration on/off scenarios kubernetes/kubernetes@db1c077 mucahitkurt, Jul 9, 2019 dependency of 81534
kubernetes/kubernetes@b052c2c v1.1.0 (which is what we currently use), does not expose metrics which makes it impossible to migrate. # Conflicts: # staging/src/k8s.io/apiextensions-apiserver/go.sum # staging/src/k8s.io/apiserver/go.mod # staging/src/k8s.io/apiserver/go.sum # staging/src/k8s.io/kube-aggregator/go.sum # staging/src/k8s.io/legacy-cloud-providers/go.sum # staging/src/k8s.io/sample-apiserver/go.sum # vendor/modules.txt Cherry-pick notes: . Manually pick up github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 vendor changes: /hack/pin-dependency.sh github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 /hack/update-vendor.sh removed SMD code changes as it is not compatible with existing arktos code.
…cyregistry logic kubernetes/kubernetes@b037203 logicalhan, Aug 22, 2019 Cherry-pick notes: skipped: staging/src/k8s.io/component-base/metrics/registry.go staging/src/k8s.io/component-base/metrics/legacyregistry/registry.go staging/src/k8s.io/component-base/metrics/version.go staging/src/k8s.io/component-base/metrics/version/base.go hack/lib/verison.sh Reason: Merged 04/2020 perf-test metrics code into arktos on 08/03/2020; hack/lib/verison.sh changes break arktos-up.sh
kubernetes/kubernetes@9309f16 logicalhan, Aug 22, 2019
kubernetes/kubernetes@94b612f logicalhan, Aug 22, 2019 cherry-pick notes: . manually merged changes in staging/publishing/import-restrictions.yaml staging/publishing/rules.yaml . run hack/update-vendor.sh picked changes related to this commit left rest of update vendor to separate commit
kubernetes/kubernetes@466980d logicalhan, Aug 28, 2019 depends on 80874 # Conflicts: # cmd/kube-apiserver/app/BUILD # staging/publishing/import-restrictions.yaml # staging/src/k8s.io/apiserver/pkg/authentication/request/x509/x509.go # staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go # staging/src/k8s.io/apiserver/pkg/storage/etcd3/metrics/metrics.go # staging/src/k8s.io/apiserver/pkg/storage/storagebackend/factory/BUILD # staging/src/k8s.io/apiserver/pkg/storage/storagebackend/factory/etcd3.go # staging/src/k8s.io/kube-aggregator/go.mod # staging/src/k8s.io/kube-aggregator/pkg/controllers/status/BUILD # staging/src/k8s.io/legacy-cloud-providers/go.sum # vendor/modules.txt Cherry-pick notes: The following file needs further change and validation due to merge conflicts and arktos changes: . staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go * staging/src/k8s.io/apiserver/pkg/storage/etcd3/metrics/metrics.go
….4.4 Without changes, those code does not compile for stability framework migration. Those code are not in 1.18 or 2021-2-5 master
…file kubernetes/kubernetes@6eee64c logicalhan, Aug 28, 2019 depends on 80874
… for clarity kubernetes/kubernetes@4e5d906 logicalhan, Aug 28, 2019 # Conflicts: # staging/src/k8s.io/apiserver/pkg/authentication/request/x509/x509.go
kubernetes/kubernetes@1700a31 logicalhan, Aug 28, 2019
kubernetes/kubernetes@23b69cf sjenning, Aug 15, 2019 dependency of 81534
…ity framework kubernetes/kubernetes@3a50917 logicalhan, Aug 28, 2019 # Conflicts: # pkg/kubelet/kuberuntime/BUILD # pkg/kubelet/kuberuntime/instrumented_services_test.go # pkg/kubelet/metrics/metrics.go # pkg/kubelet/prober/BUILD # pkg/kubelet/prober/prober_manager.go # pkg/kubelet/server/server.go # pkg/volume/util/operationexecutor/BUILD # pkg/volume/util/operationexecutor/operation_generator_test.go # staging/src/k8s.io/component-base/metrics/processstarttime.go
… for clarity kubernetes/kubernetes@6f70f78 logicalhan, Aug 28, 2019
kubernetes/kubernetes@8da448d logicalhan, Aug 28, 2019
kubernetes/kubernetes@59db3ac logicalhan, Aug 29, 2019
kubernetes/kubernetes#81626 logicalhan, Aug 29, 2019
Sindica
force-pushed
the
1.18-authbenchmark-metrics-framework-2ndtry
branch
from
796c3ac
to
15fc222
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable promethus metrics for KCM, Scheduler, Kubelet, and new metrics for api server, Arktos needs to pick up 1.18 changes mainly from this issue: kubernetes/enhancements#1206
In this PR, we have the following changes: