Resolve all frontend linting issues #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukavdplas
approved these changes
Dec 14, 2023
|
I don't really know where to start with reviewing this, I'm afraid: I don't really experience any linting issues? What were the issues for you? You can also brief me in person if that's easier! |
|
It's no problem if you don't review it, more of a heads up. If you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a frustrated mood I decided to kill some linting errors and warnings.
There is a lot of auto formatting, so a full review might be impractical. I advise you to look at
.eslintrc.jsonand see if you agree with the rule changes. Removed rules did not generate any linting warnings/errors, so were deemed superfluous.