Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add date_range mapping type #1357

Merged
merged 8 commits into from
Jan 11, 2024
Merged

add date_range mapping type #1357

merged 8 commits into from
Jan 11, 2024

Conversation

BeritJanssen
Copy link
Contributor

Close #1292 .

Copy link
Contributor

@lukavdplas lukavdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can you add a screenshot of what this looks like in the document view?

@lukavdplas
Copy link
Contributor

By the way, could you adjust your autoformatter to only format your changes rather than the whole file? If you want to format existing code, I would prefer a separate PR like #1356

@BeritJanssen
Copy link
Contributor Author

BeritJanssen commented Dec 20, 2023

This is how it now looks in the document overview for a testset from the peaceportal-epidat corpus:
Screenshot 2023-12-20 at 14 53 33

NB: we still need to address #1257 before this becomes really useful for corpora with large date ranges. Since peaceportal-iis features BC data, PeacePortal is probably not the best candidate for implementing the date filter - but it did prove a nice proof of concept for the date_range type.

@BeritJanssen BeritJanssen merged commit 7160b6e into develop Jan 11, 2024
1 check passed
@BeritJanssen BeritJanssen deleted the feature/date-range-field branch January 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standardised nested date mapping
2 participants