-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/angular 17 #1529
Feature/angular 17 #1529
Conversation
Disables ngx-scroll-position-restoration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've only tested locally with the JMIG corpus, there everything is functional.
You can address this console warning defaultLabel property is deprecated since 16.6.0, use placeholder instead
for primeng multiselect.
Note for Docker use, need to rebuild the containers or webpack complains about Edge version.
@@ -0,0 +1 @@ | |||
18.17.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just 18
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few libraries that are pinned lower than they could be because they require a higher minor verion of node. So the specific pin to 18.17.1
is necessary here.
That bug can cause some very annoying behaviour (if I recall correctly, it was not limited to visualisation options); since this update does not bring any direct improvements to the user, can we hold off on merging it?
I don't have any PDF data locally; perhaps the test server is the easiest place to check this? |
#1408 depends on a newer Angular version, so I'm afraid we cannot hold this off for too long. |
By the way, can these warnings be ignored or should they be addressed?
|
I have added them to the peer dependencies in |
Resolves #1329
A few important notes:
.nvmrc
file with the server versionng2-pdf-viewer
. i don't have data to test this. @lukavdplas or @BeritJanssen would you be so kind to check if the pdf viewer still works?