Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map visualization #1549

Closed
wants to merge 19 commits into from
Closed

Map visualization #1549

wants to merge 19 commits into from

Conversation

ar-jan
Copy link
Contributor

@ar-jan ar-jan commented Apr 24, 2024

WiP on top of #1529.

Includes update to rxjs 7, needed for ngx-maplibre-gl.

I couldn't get ngx-maplibre-gl to work without setting allowSyntheticDefaultImports, although it seems like this shouldn't be needed.

TODO:

  • Use different style / source tiles for the base layer
  • Labels? (link to record?)
  • Clustering?

JeltevanBoheemen and others added 19 commits April 4, 2024 11:36
Disables ngx-scroll-position-restoration
Name conflict with ngx-maplibre-gl ("import as" does not seem to work:
"'mgl-map' is not a known element")
allowSyntheticDefaultImports seems to be needed:
  node_modules/@types/mapbox__point-geometry/index.d.ts:40:1
  export = Point;
  This module is declared with 'export =', and can only be used with
  a default import when using the 'allowSyntheticDefaultImports' flag.
@ar-jan ar-jan mentioned this pull request May 1, 2024
@ar-jan
Copy link
Contributor Author

ar-jan commented Sep 5, 2024

Map visualization was instead added using vega in #1629.

@ar-jan ar-jan closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants