fix: return correct exit code when one env failed #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
changed the title
jiacai2050
commented
Dec 30, 2022
| @@ -44,15 +44,12 @@ impl EnvController for MyController { | |||
|
|
|||
| #[tokio::main] | |||
| async fn main() { | |||
| let args: Vec<String> = env::args().collect(); | |||
There was a problem hiding this comment.
Remove unnecessary part, the basic example should be as simple as possible.
jiacai2050
force-pushed
the
fix-exit-code
branch
from
f500c2f
to
9f590c7
Compare
waynexia
reviewed
Dec 30, 2022
| @@ -44,15 +44,12 @@ impl EnvController for MyController { | |||
|
|
|||
| #[tokio::main] | |||
| async fn main() { | |||
| let args: Vec<String> = env::args().collect(); | |||
jiacai2050
force-pushed
the
fix-exit-code
branch
from
9f590c7
to
c70599a
Compare
waynexia
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #16
Rationale for this change
When one env run failed, its error will be ignored, which is not what we expect.
What changes are included in this PR?
Are there any user-facing changes?
No
How does this change test
New bad example