Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tween.js dependency #11324

Closed
jjhembd opened this issue Jun 1, 2023 · 1 comment · Fixed by #11387
Closed

Update tween.js dependency #11324

jjhembd opened this issue Jun 1, 2023 · 1 comment · Fixed by #11387

Comments

@jjhembd
Copy link
Contributor

jjhembd commented Jun 1, 2023

The latest major version of tween.js results in build warnings:

  Build/Cesium/Cesium.js  3.7mb ⚠️
⚡ Done in 1556ms
▲ [WARNING] Import "Easing" will always be undefined because the file "node_modules/@tweenjs/tween.js/dist/tween.cjs.js" has no exports [import-is-undefined]
    packages/engine/Source/Core/EasingFunction.js:1:9:
      1 │ import { Easing } from "@tweenjs/tween.js";~~~~~~
▲ [WARNING] Import "Tween" will always be undefined because the file "node_modules/@tweenjs/tween.js/dist/tween.cjs.js" has no exports [import-is-undefined]
    packages/engine/Source/Scene/TweenCollection.js:8:9:
      8 │ import { Tween as TweenJS } from "@tweenjs/tween.js";~~~~~

These warnings will need to be resolved before updating the dependency.

@ggetz
Copy link
Contributor

ggetz commented Jun 1, 2023

Based on the docs, it looks like we'd want to make sure the import points to tween.es.js.

ggetz pushed a commit that referenced this issue Jun 1, 2023
* Update dependencies

* Update tween.js

* Revert tween.js version (see #11324)

* Revert dependency changes that only affected patch versions

---------

Co-authored-by: Jeshurun Hembd <jeshurun@cesium.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants