Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency updates #11325

Merged
merged 4 commits into from
Jun 1, 2023
Merged

dependency updates #11325

merged 4 commits into from
Jun 1, 2023

Conversation

jjhembd
Copy link
Contributor

@jjhembd jjhembd commented Jun 1, 2023

Updates a few outdated npm dependencies.

tween.js is not updated yet, pending resolution of #11324.

@cesium-concierge
Copy link

Thanks for the pull request @jjhembd!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@jjhembd jjhembd marked this pull request as ready for review June 1, 2023 15:11
@jjhembd jjhembd requested a review from ggetz June 1, 2023 15:11
"@aws-sdk/client-s3": "^3.276.0",
"@aws-sdk/lib-storage": "^3.276.0",
"@rollup/plugin-commonjs": "^24.0.1",
"@rollup/plugin-node-resolve": "^15.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the old version is still compatible, we usually don't bump the patch versions. The exception would be if the old version is no longer working for whatever reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reverted the changes that only affected patch versions. All changes should now be minor or major version updates.

@ggetz
Copy link
Contributor

ggetz commented Jun 1, 2023

Thanks @jjhembd! I've tested the updates, and everything is looking good.

Just that one comment, and this should be good to go.

@ggetz
Copy link
Contributor

ggetz commented Jun 1, 2023

Looks great, thanks @jjhembd!

@ggetz ggetz merged commit b2d169d into main Jun 1, 2023
@ggetz ggetz deleted the npm-updates branch June 1, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants