Skip to content

Add hack to avoid Firefox styling bug #12704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggetz merged 2 commits into from
Jul 1, 2025
Merged

Add hack to avoid Firefox styling bug #12704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c93f94
add a space to stylesheets for Firefox bug
jjspace Jun 30, 2025
35f062c
Merge remote-tracking branch 'origin/main' into sandcastle-ff-hack
jjspace Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Apps/Sandcastle/CesiumSandcastle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,10 @@ require({

// Apply user HTML to bucket.
const htmlElement = bucketDoc.createElement("div");
htmlElement.innerHTML = htmlEditor.getValue();
// Stylesheet imports are weirdly broken in Firefox 140. This is a hacky workaround
// https://github.com/CesiumGS/cesium/issues/12700
const htmlCode = htmlEditor.getValue().replace(/@import/, "@import ");
htmlElement.innerHTML = htmlCode;
bucketDoc.body.appendChild(htmlElement);

const onScriptTagError = function () {
Expand Down Expand Up @@ -1176,7 +1179,9 @@ require({
baseHref = `${baseHref.substring(0, pos)}/gallery/`;

const code = jsEditor.getValue();
const html = htmlEditor.getValue();
// Stylesheet imports are weirdly broken in Firefox 140. This is a hacky workaround
// https://github.com/CesiumGS/cesium/issues/12700
const html = htmlEditor.getValue().replace(/@import/, "@import ");
const data = makeCompressedBase64String([code, html, baseHref]);

let url = getBaseUrl();
Expand Down