Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix blinking polyline" #7373

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Dec 3, 2018

Reverts #6955

Fixes #7365
Fixes #7368

Never merge a PR right before the release

@lilleyse please open whatever issues necessary since we're reverting #6955

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor

mramato commented Dec 3, 2018

Thanks, please re-open any of the issues that PR closed and we'll revert the revert ASAP and keep the PR open for @bagnell to finish up.

@mramato mramato merged commit 155b6d7 into master Dec 3, 2018
@hpinkos
Copy link
Contributor Author

hpinkos commented Dec 3, 2018

#6741 was the issue we globbed a bunch of random polyline artifact problems onto. In the initial comment I asked @lilleyse to open a new issue for the specific problem since he created some other separate issues from #6741

@mramato mramato deleted the revert-6955-fix-blinking-polyline branch December 3, 2018 19:59
@lilleyse
Copy link
Contributor

lilleyse commented Dec 3, 2018

Opened #7374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants