CesiumMath.factorial has issue #7888

[rshaikhha]

current version of CesiumMath.factorial function has a bug reported in issue #7888.
the problem can be fixed by a simple logic correction

[cesium-concierge]

Thanks for the pull request @rshaikhha!

• ❌ Missing CLA.
  • Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
• ❔ Unit tests were not updated.
  • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

[rshaikhha]

This request is ready

[rshaikhha]

Contributor License Agreement (CLA) set via email rshaikhha@gmail.com

[hpinkos]

Thanks @rshaikhha! We got the email, but the person who reviews the CLAs is out of the office. We'll review this PR as soon as we get the okay.

[rshaikhha]

@hpinkos Thanks Hannah, any news from CLA?

[cesium-concierge]

Thanks again for your contribution @rshaikhha!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[cesium-concierge]

Thanks again for your contribution @rshaikhha!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[OmarShehata]

This was actually fixed in #7969. Thanks again for reporting this!