Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math.Factorial doesn't work #7969

Merged
merged 3 commits into from
Jun 27, 2019
Merged

Math.Factorial doesn't work #7969

merged 3 commits into from
Jun 27, 2019

Conversation

tfili
Copy link
Contributor

@tfili tfili commented Jun 27, 2019

Fixed factorial to actually work. It would only work if you called it in a loop in order, so I changed the test to not do that

… in a loop in order, so I changed the test to not do that
@cesium-concierge
Copy link

Thanks for the pull request @tfili!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Looks good, factorial actually works now!

Thanks @tfili !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants