Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webgl2 remove OES_standard_derivative extension #8977

Merged
merged 3 commits into from
Jun 21, 2020
Merged

Conversation

baothientran
Copy link
Contributor

@baothientran baothientran commented Jun 20, 2020

@baothientran baothientran requested a review from lilleyse June 20, 2020 19:08
@cesium-concierge
Copy link

Thanks for the pull request @baothientran!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

CHANGES.md Outdated
@@ -21,6 +21,9 @@
- Fixed a bug where silhouette postprocess doesn't work in WebGL 2. [#7952](https://github.com/CesiumGS/cesium/issues/7952)
- Fixed an error of applying clip planes to globe when enabling WebGL 2.0 [#7712](https://github.com/CesiumGS/cesium/issues/7712)
- Fixed a bug where half-float texture doesn't have correct WebGL 2.0 parameter [#8975](https://github.com/CesiumGS/cesium/pull/8975)
- Fixed a bug where the label's text is not anti-alias when enabling WebGL 2.0 [#797](https://github.com/CesiumGS/cesium/issues/797#issuecomment-646884821)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed a bug where the label's text is not anti-alias when enabling WebGL 2.0 [#797](https://github.com/CesiumGS/cesium/issues/797#issuecomment-646884821)
- Fixed a bug where the label's text is not anti-aliased when enabling WebGL 2.0 [#797](https://github.com/CesiumGS/cesium/issues/797#issuecomment-646884821)

CHANGES.md Outdated
@@ -21,6 +21,9 @@
- Fixed a bug where silhouette postprocess doesn't work in WebGL 2. [#7952](https://github.com/CesiumGS/cesium/issues/7952)
- Fixed an error of applying clip planes to globe when enabling WebGL 2.0 [#7712](https://github.com/CesiumGS/cesium/issues/7712)
- Fixed a bug where half-float texture doesn't have correct WebGL 2.0 parameter [#8975](https://github.com/CesiumGS/cesium/pull/8975)
- Fixed a bug where the label's text is not anti-alias when enabling WebGL 2.0 [#797](https://github.com/CesiumGS/cesium/issues/797#issuecomment-646884821)
- Fixed a bug where polyline get squashed when zooming when enabling WebGL 2.0 [#797](https://github.com/CesiumGS/cesium/issues/797#issuecomment-646918076)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed a bug where polyline get squashed when zooming when enabling WebGL 2.0 [#797](https://github.com/CesiumGS/cesium/issues/797#issuecomment-646918076)
- Fixed a bug where polylines get squashed when zooming when enabling WebGL 2.0 [#797](https://github.com/CesiumGS/cesium/issues/797#issuecomment-646918076)

@lilleyse
Copy link
Contributor

Great to see three bugs knocked out that easily

@lilleyse lilleyse merged commit 608b93d into master Jun 21, 2020
@lilleyse lilleyse deleted the webgl2-derivative branch June 21, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants