Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech Debt: unconfirmed UserFactory #97

Closed
ChaelCodes opened this issue Oct 17, 2021 · 1 comment · Fixed by #114
Closed

Tech Debt: unconfirmed UserFactory #97

ChaelCodes opened this issue Oct 17, 2021 · 1 comment · Fixed by #114
Assignees
@zedbydade

Comments

@ChaelCodes
Copy link
Owner

Description

In #82, we made the decision to update the unconfirmed trait of the UserFactory. This reduced the complexity of this PR and allowed us to ship unconfirmed users quicker, which has been instrumental in onboarding new contributors and PR review. However, we'd like to properly test the flows for unconfirmed users who have access to the repository.

Changes

  • Create an overdue_unconfirmed trait with the current code of the unconfirmed trait.
  • Update the existing tests with overdue_unconfirmed.
  • Write new tests that prove an unconfirmed user can create a profile, attend events, and view profiles.
@ChaelCodes ChaelCodes mentioned this issue Oct 17, 2021
Merged
@zedbydade
Copy link
Contributor

I will go work on this, if there is no problem.

This was referenced Oct 26, 2021
Closed
Merged
ChaelCodes pushed a commit that referenced this issue Oct 27, 2021
@zedbydade @ChaelCodes
#97: Tech Debt: unconfirmed UserFactory
a9a6626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zedbydade zedbydade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#97: Tech Debt: unconfirmed UserFactory
#97 Tech Debt: unconfirmed UserFactory
2 participants
@ChaelCodes @zedbydade