#97 Tech Debt: unconfirmed UserFactory #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove notice from individual pages * change datetime_field to datetime_local_field * specs use factories * specs use subjects * refactor authenticate_user * fix bugs in user/profile policy revealed by refactor * customize factory * move root to events
Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/sporkmonger/addressable/releases) - [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md) - [Commits](sporkmonger/addressable@addressable-2.7.0...addressable-2.8.0) --- updated-dependencies: - dependency-name: addressable dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
* README updates
Add article to example description. Co-authored-by: Corey Haines <coreyhaines@gmail.com>
Bumps [tar](https://github.com/npm/node-tar) from 6.1.0 to 6.1.5. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.0...v6.1.5) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
* Use chael.codes (because it's the only domain we have) * Setup SMTP config * Set from email to 'confbuddies@chael.codes'
Bumps [puma](https://github.com/puma/puma) from 5.3.2 to 5.5.1. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v5.3.2...v5.5.1) --- updated-dependencies: - dependency-name: puma dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
This will account for the fact that handles must be unique and match the viable url format.
We've removed both the AddHandleToEvents and ChangeHandleToEvents migrations, because it's possible to complete both changes in a single migration (AddIndexToEvents). Add support controller and about page
* Added show link via optional parameter in the `buttons method inside application_helper`. Styled the `/event_attendees` page to look similar to the profiles page in order to keep the styles and buttons consistent. Finally changed the id's to the profile and event names.
Added PR template with: - Description of Feature or Issue - including prompt for issue to close - Checklist for specs and build checks - User facing changes, asking for screenshots if applicable
* Add user sign condition to new event button * Spec refactor new event button condition * Button condition converted Pundit check
* Event Attendess organizer boolean migrations * Organizer checkbox and organizer as permitted param * Organizer policies and testings
* Added documentation to CONTRIBUTING.md Added collapsible section (since the details are quite long in comparison to the rest of the document) to the contributing.md to explain forking repositories. This is split up into sections of: Forking the repository and keeping up to date (syncing) Dont share event 51 (#2) * Add sign_in method to event_attendees index route * Associate current_user to profile user Adding test to validate if an event_attendees created by another user is not displayed. Add support controller and about page Add support controller and about page Add overdue_unconfirmed tests
author Rachael Wright-Munn <rachaellw5.1@gmail.com> 1635102379 +0000 committer Francisco Paradella <franciscoleite.dev@protonmail.com> 1635202508 +0000 Control who can see the Profile based on Profile visibility Dont share event 51 (#2) * Add sign_in method to event_attendees index route * Associate current_user to profile user Adding test to validate if an event_attendees created by another user is not displayed. Add support controller and about page Remove support resources Add support controller and about page Add overdue_unconfirmed tests
|
I will rebase this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Feature or Issue
closes #97
Checklist
User-Facing Changes