Remove herumi browser specific code #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
reviewed
Dec 7, 2020
86 tasks
matthewkeil
force-pushed
the
dapplion/bump-herumi-uint8-bug
branch
from
f544c28 to
aeaf4a4
Compare
Merged
|
I think this probably should get deleted... What do you think @jeluard and @wemeetagain ? |
|
Once Until then I think we should be good? Although I am not clear what the use of noble's |
|
Agreed @jeluard. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated by @matthewkeil:
Came to delete this PR but noticed it sort of ties in with what @jeluard is doing in #178 . Not sure if we want to keep this or close it.... Up for review though so we can clean the PR board.