Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default logging filters even if RUST_LOG is set. #1504

Closed
lemmih opened this issue Mar 28, 2022 · 1 comment · Fixed by #1530
Closed

Use default logging filters even if RUST_LOG is set. #1504

lemmih opened this issue Mar 28, 2022 · 1 comment · Fixed by #1530
Assignees
@jdjaustin
Labels
CLI Priority: 4 - Low Limited impact and can be implemented at any time Type: Enhancement

Comments

@lemmih
Copy link
Contributor

lemmih commented Mar 28, 2022

Issue summary

Forest has a set of default logging filters. These filters are quite sensible but they're only used when the RUST_LOG environment variable is not set. Setting RUST_LOG to chain_sync=debug doesn't just change the logging setting for the chain_sync component, it unfortunately also clears all the default filters.

Forest should be changed to always start with the default set of filters and then allow RUST_LOG to augment them.

Other information and links

The logging filters are built in forest/src/logger/mod.rs.
@lemmih lemmih added Priority: 4 - Low Limited impact and can be implemented at any time Type: Enhancement CLI labels Mar 28, 2022
@elmattic
Copy link
Contributor

Btw, gossamer is using its config file to drive components log configuration:

https://chainsafe.github.io/gossamer/usage/configuration/#configuration

Could be nice to have too.

@jdjaustin jdjaustin mentioned this issue Mar 30, 2022
Closed
jdjaustin added a commit that referenced this issue Mar 30, 2022
@jdjaustin
default logging filters #1504
9a0f91f
jdjaustin added a commit that referenced this issue Apr 1, 2022
@jdjaustin
log: don't override default filters (#1504)
5024563
@jdjaustin jdjaustin mentioned this issue Apr 1, 2022
Merged
jdjaustin added a commit that referenced this issue Apr 4, 2022
@jdjaustin
log: don't override default filters (#1504)
0c21654
jdjaustin added a commit that referenced this issue Apr 5, 2022
@jdjaustin
log: don't override default filters (#1504) (#1530)
ebed40a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdjaustin jdjaustin

Labels
CLI Priority: 4 - Low Limited impact and can be implemented at any time Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log: don't override default filters (#1504) ChainSafe/forest
3 participants
@lemmih @jdjaustin @elmattic