Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: don't override default filters (#1504) #1530

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

jdjaustin
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • don't override default filters when RUST_LOG environment variable is set

Reference issue to close (if applicable)

Closes #1504 .

Not sure if there is a default test suite; please advise best way to test if possible.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1530 (0c21654) into main (0c5ab30) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
- Coverage   44.42%   44.41%   -0.01%     
==========================================
  Files         310      310              
  Lines       28112    28112              
==========================================
- Hits        12488    12487       -1     
- Misses      15624    15625       +1     
Impacted Files Coverage Δ
forest/src/logger/mod.rs 0.00% <0.00%> (ø)
vm/actor/src/builtin/miner/mod.rs 33.49% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a251811...0c21654. Read the comment docs.

Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, quite useful first PR!

@jdjaustin jdjaustin force-pushed the jdjaustin/fix-default-logging branch from 5024563 to 0c21654 Compare April 4, 2022 19:43
@jdjaustin jdjaustin merged commit ebed40a into main Apr 5, 2022
@jdjaustin jdjaustin deleted the jdjaustin/fix-default-logging branch April 5, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use default logging filters even if RUST_LOG is set.
4 participants